Retry macOS tests with pytest-rerunfailures - #508
Open
goodboy wants to merge 1 commit into
Open
Conversation
Give only the macOS matrix leg two retries so actor/PTY timing flakes do not strand otherwise-green runs. Linux and Windows remain strict first-attempt jobs, while persistent macOS failures stay red after the final visible rerun. Deats, - add the pytest-dev-maintained plugin to testing deps - keep a one-second delay between macOS attempts - validate the workflow, lock and both observed flaky test areas Prompt-IO: ai/prompt-io/opencode/20260821T052052Z_3690e43a_prompt_io.md (this patch was generated in some part by `opencode` using `gpt-5.6-sol` (`openai`))
There was a problem hiding this comment.
🟢 Approval recommended
The only review comment is a non-blocking nit about the Windows failure-policy wording.
Pull request overview
Adds macOS-only pytest retries to reduce transient CI flakes while preserving final failures.
Changes:
- Adds and locks
pytest-rerunfailures. - Configures two macOS retries with a one-second delay.
- Records prompt and generation metadata.
File summaries
| File | Summary |
|---|---|
uv.lock |
Locks the new testing dependency. |
pyproject.toml |
Adds pytest-rerunfailures. |
ai/prompt-io/opencode/20260821T052052Z_3690e43a_prompt_io.raw.md |
Records raw generation and validation details. |
ai/prompt-io/opencode/20260821T052052Z_3690e43a_prompt_io.md |
Records prompt and implementation metadata. |
.github/workflows/ci.yml |
Adds conditional macOS retries; a minor nit notes Windows remains non-blocking despite the description. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| --spawn-backend=${{ matrix.spawn_backend }} | ||
| --tpt-proto=${{ matrix.tpt_proto }} | ||
| --capture=fd | ||
| --reruns=${{ matrix.os == 'macos-latest' && 2 || 0 }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give only the macOS matrix leg two retries so actor/PTY timing flakes do not strand otherwise-green runs. Linux and Windows remain strict first-attempt jobs, while persistent macOS failures stay red after the final visible rerun.
Deats,
Prompt-IO: ai/prompt-io/opencode/20260821T052052Z_3690e43a_prompt_io.md
(this patch was generated in some part by
opencodeusinggpt-5.6-sol(openai))