add date pick up option and infer ui extension cdn urls#1405
Merged
Conversation
🦋 Changeset detectedLatest commit: b8dd7fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wcole1-godaddy
approved these changes
Jul 8, 2026
wcole1-godaddy
left a comment
Contributor
There was a problem hiding this comment.
Reviewed locally and approved. Verification run in a detached temp worktree: @godaddy/localizations build, @godaddy/react typecheck, targeted Vitest suites, @godaddy/react build, @godaddy/react lint, and git diff --check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit local pickup scheduling modes so checkout can support date-only pickup without relying on missing time slots or legacy
pickupWindowInDaysbehavior.This introduces a new optional
pickupModevalue on store operating hours:asap— no date/time selectors; fulfillment uses ASAP behavior.dateOnly— shows a pickup date selector only; no time selector or “No available time slots” warning.dateAndTime— existing scheduled pickup behavior with date + selectable time slots.Backwards compatibility is preserved: if
pickupModeis omitted, checkout keeps the existing behavior wherepickupWindowInDays: 0means ASAP-only and any non-zero window means scheduled date/timepickup.
This also hardens UI extension script loading by no longer trusting
cdnUrlfrom API responses. Instead, UI extension bundle URLs are derived from the trustedapiHostconfigured onGoDaddyProvider.Changeset
Test Plan
Added/updated pickup mode tests covering:
pickupWindowInDays: 0ASAP behaviorasapdateOnlydateAndTimeAdded/updated UI extension runtime tests covering:
apiHostcdnUrlis ignoredValidated with:
For the checkout-api schema changes, validated with: