Skip to content

docs: document "has multiple values" response type in Wait for Response - #640

Open
SangeetaMishr wants to merge 7 commits into
mainfrom
docs/wait-for-response-has-multiple-values
Open

docs: document "has multiple values" response type in Wait for Response#640
SangeetaMishr wants to merge 7 commits into
mainfrom
docs/wait-for-response-has-multiple-values

Conversation

@SangeetaMishr

@SangeetaMishr SangeetaMishr commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #399

The Wait for Response node's "Response Type" dropdown has a has multiple values option that wasn't documented at all. This adds a "5. has multiple values" subsection under Text-based responses, explaining:

  • How it matches (every word in the contact's reply must come from the response criteria list — the reverse subset check compared to has all of the words)
  • How it differs from has any of the words (which only needs one matching word)
  • A comparison table with example replies against both operators

Verification

The behavior is described directly from the matching logic in glific/glific:

  • lib/glific/flows/case.ex (do_execute(%{type: "has_multiple"} ...), using MapSet.subset?/2)
  • lib/glific.ex (Glific.make_set/2, which shows criteria/replies are split on commas, semicolons, and whitespace, case-insensitively)
  • test/glific/flows/case_test.exs ("test the execute function for has_multiple"), which confirms the subset behavior

Test plan

  • Docs site renders the new section correctly (table + image)
  • Reviewer confirms the described matching behavior against the app

Summary by CodeRabbit

  • Documentation
    • Updated the “Last Updated” metadata from October 2025 to July 2026.
    • Clarified text-response matching options, including “has all of the words.”
    • Added guidance for “has multiple values,” with validation rules, comparisons, examples, and a screenshot.

Explains how it differs from "has any of the words" and adds a
comparison example, per user question in #399.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f7ac65b6-db1e-47a7-bc41-0bff7065ff23

📥 Commits

Reviewing files that changed from the base of the PR and between c4ea4ac and e15e9aa.

📒 Files selected for processing (1)
  • docs/4. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact to respond.md

📝 Walkthrough

Walkthrough

This change updates the “Wait for the contact to respond” documentation. It changes the “Last Updated” date from October 2025 to July 2026. It clarifies the “has all of the words” option and adds a “has multiple values” subsection with validation rules, comparisons, examples, and a screenshot.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change for the has multiple values response type.
Description check ✅ Passed The description explains the documentation update, matching behavior, issue reference, and verification plan.
Linked Issues check ✅ Passed The documentation covers the option’s meaning, separated values, matching behavior, and difference from has any of the words [#399].
Out of Scope Changes check ✅ Passed The changes remain within the documentation scope of issue #399, including related clarification and metadata updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request July 3, 2026 04:29 Inactive
Remove bold/backticks/table formatting per review feedback, keep
plain sentences followed by the screenshot.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions
github-actions Bot temporarily deployed to pull request July 3, 2026 04:32 Inactive
Keep the read-time/level/date header untouched per review feedback
so the diff only shows the new section.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions
github-actions Bot temporarily deployed to pull request July 4, 2026 07:35 Inactive
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact
to respond.md:
- Around line 77-87: Clarify the “has multiple values” section by describing it
as an all-tokens/subset match: every word in the contact’s reply must be present
in the configured criteria, and any extra word makes it invalid. Update the
wording in the “has multiple values” docs to make the usage boundary explicit
versus “has any of the words,” and specify whether commas are only used to
separate the criteria values or also expected in the contact response.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 86f07c55-53c9-407b-92da-8d3d451fb976

📥 Commits

Reviewing files that changed from the base of the PR and between e53d80b and 0ebb438.

📒 Files selected for processing (1)
  • docs/4. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact to respond.md

@github-actions
github-actions Bot temporarily deployed to pull request July 4, 2026 07:37 Inactive
@SangeetaMishr SangeetaMishr self-assigned this Jul 5, 2026
@SangeetaMishr
SangeetaMishr requested review from akanshaaa19 and removed request for tanuprasad530 July 8, 2026 10:28
@SangeetaMishr

Copy link
Copy Markdown
Contributor Author

@akanshaaa19 Can you please review this PR.

@github-actions
github-actions Bot temporarily deployed to pull request August 5, 2026 04:36 Inactive
…r the contact to respond.md

Co-authored-by: Akansha Sakhre <asakhre2002@gmail.com>
@github-actions
github-actions Bot temporarily deployed to pull request August 6, 2026 03:54 Inactive

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact
to respond.md:
- Line 82: Update the description of “has all of the words” in the documented
rule near line 69 to state that every criteria word must appear in the reply
while allowing additional reply values. Keep it distinct from “has only the
phrase,” and preserve the existing explanation that contrasts it with “has
multiple values.”
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d8d9af9f-096b-4d1c-b914-17139adc9003

📥 Commits

Reviewing files that changed from the base of the PR and between eee60a1 and c4ea4ac.

📒 Files selected for processing (1)
  • docs/4. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact to respond.md

@github-actions
github-actions Bot temporarily deployed to pull request August 6, 2026 04:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Has multiple values | Add in documentation

3 participants