docs: document "has multiple values" response type in Wait for Response - #640
docs: document "has multiple values" response type in Wait for Response#640SangeetaMishr wants to merge 7 commits into
Conversation
Explains how it differs from "has any of the words" and adds a comparison example, per user question in #399. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change updates the “Wait for the contact to respond” documentation. It changes the “Last Updated” date from October 2025 to July 2026. It clarifies the “has all of the words” option and adds a “has multiple values” subsection with validation rules, comparisons, examples, and a screenshot. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-640--glific-docs.netlify.app |
Remove bold/backticks/table formatting per review feedback, keep plain sentences followed by the screenshot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Keep the read-time/level/date header untouched per review feedback so the diff only shows the new section. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact
to respond.md:
- Around line 77-87: Clarify the “has multiple values” section by describing it
as an all-tokens/subset match: every word in the contact’s reply must be present
in the configured criteria, and any extra word makes it invalid. Update the
wording in the “has multiple values” docs to make the usage boundary explicit
versus “has any of the words,” and specify whether commas are only used to
separate the criteria values or also expected in the contact response.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 86f07c55-53c9-407b-92da-8d3d451fb976
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact to respond.md
|
@akanshaaa19 Can you please review this PR. |
…r the contact to respond.md Co-authored-by: Akansha Sakhre <asakhre2002@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact
to respond.md:
- Line 82: Update the description of “has all of the words” in the documented
rule near line 69 to state that every criteria word must appear in the reply
while allowing additional reply values. Keep it distinct from “has only the
phrase,” and preserve the existing explanation that contrasts it with “has
multiple values.”
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d8d9af9f-096b-4d1c-b914-17139adc9003
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/04. Wait for the contact to respond.md
Summary
Fixes #399
The
Wait for Responsenode's "Response Type" dropdown has ahas multiple valuesoption that wasn't documented at all. This adds a "5. has multiple values" subsection under Text-based responses, explaining:has all of the words)has any of the words(which only needs one matching word)Verification
The behavior is described directly from the matching logic in
glific/glific:lib/glific/flows/case.ex(do_execute(%{type: "has_multiple"} ...), usingMapSet.subset?/2)lib/glific.ex(Glific.make_set/2, which shows criteria/replies are split on commas, semicolons, and whitespace, case-insensitively)test/glific/flows/case_test.exs("test the execute function for has_multiple"), which confirms the subset behaviorTest plan
Summary by CodeRabbit