Change walk order from ByCommitTime to topological order - #2991
Open
peso wants to merge 4 commits into
Open
Conversation
peso
marked this pull request as draft
July 9, 2026 05:58
This is preparation for a log graph implementation. In case of a diamond graph where the common ancestor has a newer date than some of its children, the walk order of the current code will violate topology order. If commits are not in topology order, a graph may have to draw a parent before its child. This is confusing to the user and require extra memory for the graph render algorithm.
LogWalker uses git2, due to SharedCommitFilterFn
LogWalkerWithoutFilter is based on gix, so it touches a different part of the code.
Collaborator
|
@cruessler do you recall why we changed this in the first place? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preparation for a graph implementation.
Currently, commits are sorted by commit time without regard to parent-child relations. This means a parent with a date more recent than its child will appear before its child.
git loghas options--date-orderand--author-date-orderboth of which show no parents before all its children, before ordering commits by date.If sorted by commit time, a graph may have to draw a parent before its child. This is confusing to the user and require extra memory for the graph render algorithm. Topology order makes graph visualisation much simpler as all children are now visited before their parents.
This Pull Request prepares a PR for issue #81. It is relevant to both PR #2628 and PR #2890.
It changes the following:
I followed the checklist:
make checkwithout errors