Skip to content

Use a config value to choose whether to use the github API #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityasaky merged 1 commit into from
Jun 15, 2026
Merged

Use a config value to choose whether to use the github API #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion internal/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ type EnvConfig struct {
// on PRs where prior approvals do not hold when the base branch is
// affected by a push or a merge.
CommentOnAffectedPRs bool `envconfig:"COMMENT_ON_AFFECTED_PRS" default:"false"`

// UseGitHubAPI indicates whether to use the GitHub API for certain actions
// like determining the target tree for a merge.
UseGitHubAPI bool `envconfig:"USE_GITHUB_API" default:"false"`
}

type GittufApp struct {
Expand Down Expand Up @@ -747,7 +751,16 @@ func (g *GittufApp) handlePullRequestReview(ctx context.Context, event *github.P
return nil
}

if err := repo.AddGitHubPullRequestApprover(ctx, signer, owner, repository, pullRequestNumber, event.GetReview().GetID(), reviewerIdentifier, true, githubopts.WithGitHubBaseURL(g.Params.GitHubURL), githubopts.WithGitHubTokenSource(transport), githubopts.WithRSLEntry()); err != nil {
opts := []githubopts.Option{
githubopts.WithGitHubBaseURL(g.Params.GitHubURL),
githubopts.WithGitHubTokenSource(transport),
githubopts.WithRSLEntry(),
}
if g.Params.UseGitHubAPI {
opts = append(opts, githubopts.WithUseGitHubAPI())
}

if err := repo.AddGitHubPullRequestApprover(ctx, signer, owner, repository, pullRequestNumber, event.GetReview().GetID(), reviewerIdentifier, true, opts...); err != nil {
log.Default().Printf("Unable to create pull request approval attestation: %v", err)
return err
}
Expand Down