Skip to content

Require rich Crane PR update comments#88

Merged
mrjf merged 3 commits into
mainfrom
copilot/update-crane-pr-comments
May 28, 2026
Merged

Require rich Crane PR update comments#88
mrjf merged 3 commits into
mainfrom
copilot/update-crane-pr-comments

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

Description

Crane accepted-iteration PR updates currently identify only the pushed SHA, forcing reviewers to open the commit or diff to understand the new work. This updates the Crane workflow prompt so existing-PR updates carry the same concise review context as the PR body, migration issue, and repo-memory history.

  • Shared summary source

    • Defines one accepted-iteration summary reused across PR body, PR comment, migration issue comment, and repo-memory history.
    • Includes iteration, milestone/focus, change summary, commit/run links, score/delta/progress/parity, and CI fix attempts when available.
  • Mandatory PR update comment

    • Requires a separate add-comment safe output for accepted updates to existing PRs.
    • Prevents relying on the default push-to-pull-request-branch “Commit pushed” comment as the only reviewer-facing signal.
  • Commit fallback

    • Strengthens commit guidance so accepted commits include compact Changes: bullets before Run:.
    • Lets later summaries fall back to commit content when score/progress fields are missing.
  • Bounded output

    • Keeps comments short.
    • Ignores ci: trigger checks commits unless they are the only new commit.

Example target shape:

[bot] **Iteration {N} accepted** -- [Crane run]({run_url})

- **Commit**: [`{short_sha}`]({commit_url})
- **Change**: {one-line summary}
- **Milestone**: {milestone or current focus}
- **Score**: {migration_score} (best: {best_metric}, delta: {+/-delta})
- **Progress**: {progress fraction}
- **Tests/parity**: {parity_passing}/{parity_total} passing

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Maintenance / refactor

Testing

  • Tested locally
  • All existing tests pass
  • Added tests for new functionality (if applicable)

Copilot AI linked an issue May 26, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits May 26, 2026 23:59
Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Co-authored-by: mrjf <180956+mrjf@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Crane PR comments to summarize new commits Require rich Crane PR update comments May 27, 2026
Copilot AI requested a review from mrjf May 27, 2026 00:01
Copilot finished work on behalf of mrjf May 27, 2026 00:01
@mrjf mrjf marked this pull request as ready for review May 28, 2026 03:36
@mrjf mrjf merged commit 2bfcc12 into main May 28, 2026
14 checks passed
@mrjf mrjf deleted the copilot/update-crane-pr-comments branch May 28, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crane PR update comments should summarize new commits

2 participants