refactor: reduce largefunc findings in cmd/gh-aw/main.go and pkg/linters

[Copilot]

make golint-custom reported numerous largefunc violations (> 60 lines) concentrated in cmd/gh-aw/main.go (440-line init, 121-line compileCmd.RunE) and 21 analyzer files under pkg/linters/. All changes are purely structural — behavior, diagnostics, and CLI semantics are preserved exactly.

cmd/gh-aw/main.go

• Promoted 30 locally-scoped command vars to package-level var declarations
• Split 440-line init() into a 10-line dispatcher calling 15 focused helpers (instantiateAllCmds, registerFlagsForCmds, registerCommandGroups, configureRootCmdSettings, addCmdsToRoot, etc.)
• Extracted 121-line compileCmd.RunE closure into readCompileFlags → buildCompileConfig → runCompileCmd

pkg/linters/*

Extracted long Preorder closures and for-range loop bodies into named helpers across 21 analyzers. Representative pattern:

// Before: anonymous closure inline in run()
insp.Preorder(nodeFilter, func(n ast.Node) {
    // 80+ lines of logic
})

// After: named helper called from run()
insp.Preorder(nodeFilter, func(n ast.Node) {
    checkMapDeleteCheckNode(pass, n, noLintIndex, generatedFiles)
})

Notable extractions: validateMapClearPattern + validateDeleteBody, checkMapDeleteCheckNode + matchDeleteCallInIfBody, buildWriteStringArgs, collectMapStringBoolDecls + collectNonSetMapAssignments.

• Fixes [lint-monster] [Code Quality] Reduce largefunc findings in cmd/gh-aw and pkg/linters slice #46331

[Copilot]

Pull request overview

Refactors oversized CLI and analyzer functions while preserving behavior.

Changes:

• Decomposes compile handling and command initialization.
• Extracts focused helpers across 21 linters.
• Includes unrelated generated lockfile annotation updates.

Show a summary per file

File	Description
cmd/gh-aw/main.go	Splits compile and command initialization logic.
pkg/linters/appendbytestring/appendbytestring.go	Extracts call inspection.
pkg/linters/bytesbufferstring/bytesbufferstring.go	Extracts inspection and reporting.
pkg/linters/bytescomparestring/bytescomparestring.go	Extracts inspection and import editing.
pkg/linters/errorfwrapv/errorfwrapv.go	Extracts call inspection.
pkg/linters/execcommandwithoutcontext/execcommandwithoutcontext.go	Extracts command-call inspection.
pkg/linters/hardcodedfilepath/hardcodedfilepath.go	Extracts literal inspection.
pkg/linters/httpnoctx/httpnoctx.go	Extracts HTTP call inspection.
pkg/linters/ioutildeprecated/ioutildeprecated.go	Separates qualified and dot-import checks.
pkg/linters/largefunc/largefunc.go	Extracts function-size checking.
pkg/linters/lenstringzero/lenstringzero.go	Extracts expression inspection.
pkg/linters/mapclearloop/mapclearloop.go	Extracts pattern validation.
pkg/linters/mapdeletecheck/mapdeletecheck.go	Extracts delete-body matching.
pkg/linters/nilctxpassed/nilctxpassed.go	Extracts call inspection.
pkg/linters/seenmapbool/seenmapbool.go	Separates declaration and assignment collection.
pkg/linters/sprintferrdot/sprintferrdot.go	Extracts call inspection.
pkg/linters/sprintfint/sprintfint.go	Extracts call inspection.
pkg/linters/strconvparseignorederror/strconvparseignorederror.go	Extracts assignment inspection.
pkg/linters/stringscountcontains/stringscountcontains.go	Extracts comparison inspection.
pkg/linters/stringsindexcontains/stringsindexcontains.go	Extracts comparison inspection.
pkg/linters/timeafterleak/timeafterleak.go	Extracts enclosing-loop detection.
pkg/linters/writebytestring/writebytestring.go	Extracts inspection, argument building, and import editing.
.github/workflows/avenger.lock.yml	Updates generated action annotations.
.github/workflows/hourly-ci-cleaner.lock.yml	Updates generated action annotations.
.github/workflows/release.lock.yml	Updates generated action annotations.
.github/workflows/skillet.lock.yml	Updates generated action annotations.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 26/26 changed files
• Comments generated: 4
• Review effort level: Medium

[github-actions]

Hi @app/copilot-swe-agent 👋 — appreciate the careful write-up and the intent to preserve behavior while reducing largefunc findings. This does look relevant to the repository, but the contribution process only permits direct PRs from core team members. This PR does not follow project guidelines.

There are also no test file changes in the diff (2772 lines changed), making this refactor harder to evaluate without an issue-led implementation plan.

Please close this PR and open an issue in github/gh-aw instead.
Include:
- the specific largefunc violations to address
- the proposed refactor strategy by file/group
- confirmation that behavior/diagnostics should remain unchanged
- the validation plan (targeted tests, build, lint, and any workflow recompilation checks)
- a link back to this PR for context

Once captured as an issue, a core team member can pick it up in the expected workflow.

Generated by ✅ Contribution Check · 77.3 AIC · ⌖ 8.93 AIC · ⊞ 6.2K · ◷