Refine require-new-url-try-catch safe-argument detection

[Copilot]

require-new-url-try-catch was over-classifying some new URL(...) calls as runtime-risky. In particular, it flagged provably constant string concatenations and new URL(import.meta.url), even though both are syntactically safe and non-throwing in the cases covered here.

• Rule precision

  • teach the rule to treat recursively constant string expressions as static:
    • string literals
    • expression-less template literals
    • + concatenations composed only of the above
  • reuse the existing import.meta.url safe-value exemption for the first argument, not just the base argument

• Behavioral effect

  • stop reporting false positives such as:

    new URL("https://github.com" + "/owner/repo");
    const u = new URL(import.meta.url);

  • keep reporting genuinely dynamic inputs, including variable-based concatenation:

    const u = new URL(host + "/x");

• Coverage

  • add valid-case tests for constant concatenation and import.meta.url in first-argument position
  • add an invalid regression test confirming variable concatenation remains in scope

[github-actions]

Hey @app/copilot-swe-agent 👋 — great work on refining the require-new-url-try-catch rule! The fix for false positives on constant string concatenations and import.meta.url is well-targeted, and the added test coverage is solid. This PR looks ready for review! 🎉

Generated by ✅ Contribution Check · 74.6 AIC · ⌖ 16.7 AIC · ⊞ 6.2K · ◷

[Copilot]

Pull request overview

Refines URL lint-rule precision for statically safe arguments.

Changes:

• Recognizes recursively constant string concatenations.
• Exempts import.meta.url as the first argument.
• Adds regression coverage and changes the auto-upgrade schedule.

Show a summary per file

File	Description
eslint-factory/src/rules/require-new-url-try-catch.ts	Refines static argument detection.
eslint-factory/src/rules/require-new-url-try-catch.test.ts	Tests new valid and invalid cases.
.github/workflows/agentic-auto-upgrade.yml	Unrelated generated schedule change requiring removal.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Medium

[gh-aw-bot]

@copilot please run the pr-finisher skill, address unresolved review feedback, investigate any failed checks listed below, refresh the branch if needed, and rerun checks once ready.

Unresolved review threads (newest first):

• Copilot: Refine require-new-url-try-catch safe-argument detection #46190 (comment)

Generated by pr-sous-chef: https://github.com/github/gh-aw/actions/runs/29590499747

Generated by 👨‍🍳 PR Sous Chef · 8.3 AIC · ⌖ 10.9 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot please run the pr-finisher skill, address unresolved review feedback, investigate any failed checks listed below, refresh the branch if needed, and rerun checks once ready.

Unresolved revi...

Reverted the incidental cron schedule change in agentic-auto-upgrade.yml — restored it to "21 3 * * 5" (Friday) in commit revert: restore agentic-auto-upgrade.yml cron schedule to Friday. The URL rule refinement changes are unchanged. Local validation passes.

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.82.13