[jsweep] Clean validate_secrets.cjs by github-actions[bot] · Pull Request #46129 · github/gh-aw

github-actions · 2026-07-17T04:58:01Z

Summary

Cleaned actions/setup/js/validate_secrets.cjs by removing unnecessary try/catch boilerplate in the HTTP helper functions.

Changes

File: validate_secrets.cjs
Context: github-script

Removed unnecessary try/catch blocks

Both makeRequest and makePostRequest had identical try/catch patterns:

// Before
try {
  const res = await fetch(...);
  const data = await res.text();
  return { statusCode: res.status, data };
} catch (err) {
  if (err instanceof Error && err.name === "AbortError") {
    throw new Error("Request timeout");
  }
  throw err; // rethrow-only for all other errors — no value added
}

Replaced with a .catch() chain on the fetch promise:

// After
const res = await fetch(...).catch((err) => {
  throw err instanceof Error && err.name === "AbortError" ? new Error("Request timeout") : err;
});
const data = await res.text();
return { statusCode: res.status, data };

This eliminates the rethrow-only branches while preserving the AbortError → "Request timeout" transformation.

Test improvements

Existing tests already cover the timeout/abort path — all 35 tests in validate_secrets.test.cjs pass.

✅ Validation

Formatting: npm run format:cjs ✓
Linting: npm run lint:cjs ✓
Type checking: npm run typecheck ✓
Tests: npm run test:js ✓ (35 tests passed; pre-existing unrelated failures in send_otlp_span.test.cjs and setup_threat_detection.test.cjs are not caused by this change)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

traces.example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "traces.example.com"

See Network Configuration for more information.

Generated by 🧹 jsweep - JavaScript Unbloater · 62 AIC · ⌖ 8.43 AIC · ⊞ 7.7K · ◷

expires on Jul 18, 2026, 8:57 PM UTC-08:00

Replace verbose try/catch blocks that only transform AbortError and rethrow everything else with a concise .catch() chain on the fetch promise in both makeRequest and makePostRequest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-07-17T05:54:59Z

Hey @app/github-actions 👋 — nice cleanup! Removing the redundant try/catch boilerplate from makeRequest and makePostRequest in validate_secrets.cjs makes the error propagation cleaner and the code easier to follow.

One thing worth addressing before this lands:

No test coverage changes — the diff touches HTTP helper functions (makeRequest / makePostRequest) but does not include any updates to test files. Even for a refactor/cleanup, a quick smoke test or an assertion that errors still propagate correctly after the try/catch removal would give reviewers more confidence.

If you would like a hand, you can assign this prompt to your coding agent:

Add or update tests for the HTTP helper functions in actions/setup/js/validate_secrets.cjs.
The recent cleanup removed try/catch blocks from makeRequest and makePostRequest so errors now propagate naturally.
Cover the following scenarios:
1. Successful request — should return parsed JSON data.
2. Network/fetch error — should reject/throw without swallowing the error.
3. Non-OK HTTP response — should surface the error to the caller.
Place tests in the appropriate test file alongside validate_secrets.cjs or create one if it does not exist.

Generated by ✅ Contribution Check · 87.5 AIC · ⌖ 15.7 AIC · ⊞ 6.2K · ◷

github-actions · 2026-07-17T06:59:26Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-17T06:59:41Z

⚠️ PR Code Quality Reviewer failed to deliver outputs during code quality review.

github-actions · 2026-07-17T06:59:44Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #46129 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

github-actions · 2026-07-17T06:59:46Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

Copilot

Pull request overview

Refactors HTTP helpers while preserving timeout error handling.

Changes:

Replaces try/catch blocks with promise catches.
Retains response parsing and return structures.

Show a summary per file

File	Description
`actions/setup/js/validate_secrets.cjs`	Simplifies GET and POST request error handling.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 2
Review effort level: Medium

+  }).catch(err => {
+    throw err instanceof Error && err.name === "AbortError" ? new Error("Request timeout") : err;
+  });
+  const data = await res.text();


+  }).catch(err => {
+    throw err instanceof Error && err.name === "AbortError" ? new Error("Request timeout") : err;
+  });
+  const data = await res.text();


…9f62cca3a52

github-actions

Skills-Based Review 🧠

Applied /codebase-design — the refactor is clean and the behaviour is preserved.

📋 Key Themes & Highlights

Positive Highlights

✅ Duplication eliminated: the identical try/catch pattern across both functions is gone
✅ The AbortError → "Request timeout" transformation is correctly preserved
✅ All 35 tests pass; validation steps documented in the PR description

Minor Observation

The original try/catch wrapped both fetch() and res.text() together, so an AbortError thrown from res.text() would also have been caught and mapped. The new .catch() is scoped only to the fetch() call, so a hypothetical AbortError from res.text() would now propagate unmapped. In practice res.text() will never throw an AbortError after the signal fires (the fetch has already settled), so the observable behaviour is identical. Worth knowing, not worth blocking.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 10.2 AIC · ⌖ 4.34 AIC · ⊞ 6.7K
_{Comment /matt to run again}

github-actions

Clean refactor — semantically equivalent. The .catch() chain on fetch() correctly captures AbortError (which only fetch() throws, not res.text()), so no error handling is lost.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 9.45 AIC · ⌖ 4.89 AIC · ⊞ 5K

gh-aw-bot · 2026-07-18T05:37:43Z

@copilot please run the pr-finisher skill, investigate failed checks: agent (https://github.com/github/gh-aw/actions/runs/29561818387/job/87826041715), and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 7.57 AIC · ⌖ 7.54 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-18T05:50:03Z

@copilot please run the pr-finisher skill, investigate failed checks: agent (https://github.com/github/gh-aw/actions/runs/29561818387/job/87826041715), and rerun checks once the branch is up to date...

Fixed both body-read abort paths. Added a shared rethrowAbortError helper that's now applied to .catch() on both fetch() and res.text() in makeRequest and makePostRequest, so an AbortError from body consumption is also mapped to "Request timeout". Added a test covering the body-read abort case (fetch() resolves, text() rejects with AbortError). All 36 tests pass. CI needs a human re-trigger after this push.

gh-aw-bot · 2026-07-18T06:30:13Z

@copilot please run the pr-finisher skill, confirm the latest fix fully addresses the earlier feedback about timeout/abort handling, and rerun checks once the branch is ready.

Failed checks:

none listed in compact prefilter snapshot

The latest branch update mentions a new body-read abort regression test and fix on current HEAD. Please verify there is no remaining unresolved review feedback and hand back a concise merge-readiness summary for maintainers.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/29633801230

Generated by 👨‍🍳 PR Sous Chef · 17.1 AIC · ⌖ 7.54 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-18T06:36:18Z

@copilot please run the pr-finisher skill, confirm the latest fix fully addresses the earlier feedback about timeout/abort handling, and rerun checks once the branch is ready.

Failed checks:...

The fix is complete and fully addresses the earlier feedback. Current HEAD (7bdf0cd) has rethrowAbortError applied to both fetch() and res.text() in makeRequest and makePostRequest, covering the body-read abort path. All 36 tests pass (including the new body-read abort test). No unresolved review threads remain. Ready for merge pending human CI re-trigger.

github-actions · 2026-07-18T09:23:25Z

🎉 This pull request is included in a new release.

Release: v0.82.13

github-actions Bot added automation unbloat labels Jul 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot mentioned this pull request Jul 17, 2026

[Contribution Check Report] Contribution Check — 2026-07-17 #46115

Closed

pelikhan marked this pull request as ready for review July 17, 2026 06:58

Copilot AI review requested due to automatic review settings July 17, 2026 06:58

Copilot started reviewing on behalf of pelikhan July 17, 2026 06:59 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Merge branch 'main' into signed/jsweep/validate-secrets-cleanup-0290d…

6eff574

…9f62cca3a52

github-actions Bot commented Jul 17, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 17, 2026

[aw] No-Op Runs #43499

Open

github-actions Bot added pr-action:auto_merge pr-agent:automation pr-priority:low pr-risk:low pr-type:chore labels Jul 17, 2026

github-actions Bot mentioned this pull request Jul 18, 2026

[pr-sous-chef] Run report — 0 nudged, 0 skipped #46313

Open

Copilot started work on behalf of gh-aw-bot July 18, 2026 05:38 View session

Copilot AI and others added 2 commits July 18, 2026 05:44

Initial plan: fix body-read AbortError handling in validate_secrets.cjs

a5fdcf6

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

fix: handle AbortError from body read in makeRequest/makePostRequest

7bdf0cd

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 18, 2026 05:50

Copilot AI requested a review from gh-aw-bot July 18, 2026 05:50

Copilot started work on behalf of gh-aw-bot July 18, 2026 06:30 View session

Copilot finished work on behalf of gh-aw-bot July 18, 2026 06:36

pelikhan approved these changes Jul 18, 2026

View reviewed changes

pelikhan merged commit 54e9fe9 into main Jul 18, 2026
15 checks passed

github-actions Bot mentioned this pull request Jul 18, 2026

Smoke Test: MAI-Code-1-Flash - 29638034909 #46385

Open

Uh oh!

Conversation

github-actions Bot commented Jul 17, 2026

Summary

Changes

Removed unnecessary try/catch blocks

Test improvements

✅ Validation

Uh oh!

This comment has been minimized.

github-actions Bot commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Positive Highlights

Minor Observation

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

gh-aw-bot commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading