Skip to content

Fix sidebar icon toggle logic for desktop and mobile views#45211

Open
phsete wants to merge 1 commit into
github:mainfrom
hoephsetoet:main
Open

Fix sidebar icon toggle logic for desktop and mobile views#45211
phsete wants to merge 1 commit into
github:mainfrom
hoephsetoet:main

Conversation

@phsete

@phsete phsete commented Jul 19, 2026

Copy link
Copy Markdown

Why:

The collapse and expand icons on the sidebar are swapped.
Closes: #45210

What's being changed (if available, include any code snippets, screenshots, or gifs):

The collapse and expand icons for the sidbar are swapped.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Co-authored-by: hoesentoet <hoesentoet@gmail.com>
Copilot AI review requested due to automatic review settings July 19, 2026 17:56
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR to the GitHub Docs project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jul 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/frame/components/page-header/DocsSecondaryBar.tsx

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/how-tos/security-for-github-actions/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter contentType: rai.

@github-actions

Copy link
Copy Markdown
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects swapped sidebar icons across desktop and mobile layouts.

Changes:

  • Reverses icon selection for collapsed desktop and open mobile states.
  • Keeps labels and expanded-state semantics unchanged.

@heardjalissa9-gif heardjalissa9-gif left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood.

@heardjalissa9-gif heardjalissa9-gif left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar collapse icon is flipped with expand icon

3 participants