Promote NewRemoteFileAddresses FF#4023
Open
mbg wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Promotes the new remote-file address format to the default behavior by removing its feature flag.
Changes:
- Removes the
NewRemoteFileAddressesfeature flag and conditional checks. - Updates unit tests and proxy PR checks for unconditional support.
- Refreshes generated artifacts.
Show a summary per file
| File | Description |
|---|---|
src/feature-flags.ts |
Removes the promoted feature flag. |
src/config/remote-file.ts |
Unconditionally accepts the new address format. |
src/config/remote-file.test.ts |
Updates parsing tests for default behavior. |
src/config/file.test.ts |
Removes obsolete feature setup. |
src/config-utils.ts |
Enables new path detection unconditionally. |
src/config-utils.test.ts |
Updates remote-path tests. |
pr-checks/checks/start-proxy.yml |
Removes the obsolete feature environment variable. |
.github/workflows/__start-proxy.yml |
Generated workflow; excluded from review. |
lib/entry-points.js |
Generated JavaScript; excluded from review. |
Review details
Files excluded by content exclusion policy (2)
- .github/workflows/__start-proxy.yml
- lib/entry-points.js
- Files reviewed: 7/9 changed files
- Comments generated: 0
- Review effort level: Medium
oscarsj
approved these changes
Jul 20, 2026
Member
Author
|
I'll wait a bit before merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR promotes the
NewRemoteFileAddressesFF to make its behaviour the default, following release and rollout of the feature.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist