fix: harden credential persistence#225
Merged
Merged
Conversation
Retain refresh credentials after transient failures, cap auth file permissions, and reconcile ambiguous legacy copies behind the auth lock. Add file-backed and concurrency regression coverage and document the storage guarantees.
jlitola
added
bug
Use a writable replacement target on Windows, where mode 0400 maps to a read-only attribute and blocks rename. Keep the restrictive-mode assertion on POSIX while still exercising replacement content on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0600without broadening more-restrictive modesThis is PR 2 of the P0/P1 quality-review plan and addresses P0.2 and P1.4. PR 3 remains scoped to built-artifact smoke coverage in CI.
Verification
bun test(2,462 passed)bun run typecheckbun run format:checkbun run lint(one pre-existing warning insrc/commands/init/agent-definitions.ts)bun run buildbun run buildinpackages/mcpbun run validate:packagesbun run smoke:cli(65 steps)bun run smoke:mcp(38 steps)bun run smoke:proxy-nodeReview
An independent final review reported no findings.