fix: resolve {build_dir} in translated pages - #2198
Open
yangzhg wants to merge 1 commit into
Open
Conversation
Resolve translated includes from the language directory when they use
{build_dir}. Keep relative includes based on their source directory.
Fixes git#2197
Signed-off-by: Yang Zhengguo <yangzhgg@gmail.com>
yangzhg
changed the title
Author
|
@dscho Could you please review this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translated manual page updater leaves
{build_dir}in include paths, so the command lists are replaced by missing-file warnings.Resolve those includes from the language directory. Regular relative includes still use the directory of the source file.
I checked the current
git-html-l10ndata fores,fr,pt_BR,ru,sv,uk, andzh_HANS-CN, including nestedconfig/merge.adocfiles where available. The legacy.txtpath still works as well.Fixes #2197