feat(server-utils): Warn when bundler config has instrumented module in external#22379
Open
timfish wants to merge 1 commit into
Open
feat(server-utils): Warn when bundler config has instrumented module in external#22379timfish wants to merge 1 commit into
timfish wants to merge 1 commit into
Conversation
timfish
requested review from
isaacs,
msonnb,
mydea and
stephanie-anderson
and removed request for
a team
July 19, 2026 16:25
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
approved these changes
Jul 20, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Code and tests LGTM, but probably worth fixing the doc comment issue (assuming I'm reading that correctly).
| * bundler path ran (rather than relying on a build-time flag that wouldn't be | ||
| * visible to the runtime). | ||
| */ | ||
| /** |
Member
There was a problem hiding this comment.
It looks like this code got inserted between a doc comment and its target? Shouldn't that bit above be attached to the orchestrionTransformOptions below?
| // its diagnostics_channel calls are silently never injected. By the time | ||
| // buildStart runs, Rollup has normalized `external` (string arrays, | ||
| // RegExps or user functions) into a single predicate we can probe. | ||
| const externalizedModules = moduleNames.filter(name => rollupOptions.external(name, undefined, false)); |
Member
There was a problem hiding this comment.
Nice, I didn't realize it did that. Very convenient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users have a library we instrument in their bundler
externalconfig we should warn them about the fact that this stops it from getting instrumented!