feat(server-utils): initial module scaffolding#21200
Draft
isaacs wants to merge 1 commit into
Draft
Conversation
This is phase 1 of the plan to move all server utils into a single reusable package that can be shared across SSJS SDKs. Right now it does not do anything, but in subsequent steps: 1. Code will be moved out of @sentry/core/server, into @sentry-internal/server-utils. 2. @sentry/core/server will live on, but re-export the contents of the server-utils module. 3. To minimize the cyclical dependency (ie, server-utils depends on core for isomorphic utilities, core depends on server-utils for ./server exports), server-utils will have a types-only dependency on core, which can be removed in v11. For now, an nx override allows the cycle explicitly.
Member
Author
|
Actually it looks like this might not be possible without a breaking change, because the cycles will end up confounding TSC when it builds our code, as core and server-utils would depend on one another for types. The only option would be to shim everything, which gets pretty gross. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is phase 1 of the plan to move all server utils into a single reusable package that can be shared across SSJS SDKs.
Right now it does not do anything, but in subsequent steps: