fix(cloudflare): Use original waitUntil to not create a deadlock#21197
Open
JPeer264 wants to merge 1 commit into
Open
fix(cloudflare): Use original waitUntil to not create a deadlock#21197JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
JPeer264
requested review from
andreiborza,
mydea and
s1gr1d
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6da5af9. Configure here.
|
|
||
| type FlushLockRegistry = { | ||
| readonly locks: Set<FlushLockInternal>; | ||
| readonly originalWaitUntil: ExecutionContext['waitUntil']; |
There was a problem hiding this comment.
Unused originalWaitUntil field on FlushLockRegistry
Low Severity
The new originalWaitUntil field on FlushLockRegistry is stored in the registry object but never read from it — only registry.locks is ever accessed. The actual original-waitUntil lookup goes through the separate originalWaitUntilMap WeakMap. This makes the field dead code, storing a redundant reference that adds confusion about which mechanism is authoritative for retrieving the original function.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6da5af9. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to: #21156
This prevents a deadlock in the
waitUntil, which happened in the sentry-mcp: