ref(node): Refactor usage of hrTime utilities from @opentelemetry/core#21191
Open
mydea wants to merge 2 commits into
Open
ref(node): Refactor usage of hrTime utilities from @opentelemetry/core#21191mydea wants to merge 2 commits into
hrTime utilities from @opentelemetry/core#21191mydea wants to merge 2 commits into
Conversation
Getting rid of this usage from `@opentelemetry/core`.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These can easily be rewritten to use our existing utils, actually making things easier often (because it often creates hrTime just to convert it to a number, we can skip this step...).
Also removes the core dependency from nestjs package, as this is not actually used there.
Also adjusts the vendor-otel skill to be explicit about it being ok to change vendored code afterwards.