WIP feat(opentelemetry): Add SentryTraceProvider#21181
Draft
andreiborza wants to merge 5 commits into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69
Compare
mydea
reviewed
May 27, 2026
| */ | ||
| public recordException(_exception: unknown, _time?: number | undefined): void { | ||
| // noop | ||
| public recordException(exception: unknown, time?: SpanTimeInput | undefined): void { |
Member
There was a problem hiding this comment.
I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a44215e. Configure here.
|
|
||
| if (typeof grpcCodeAttribute === 'string') { | ||
| return { code: SPAN_STATUS_ERROR, message: GRPC_STATUS_CODE_MAP[grpcCodeAttribute] || 'unknown_error' }; | ||
| } |
There was a problem hiding this comment.
gRPC numeric status codes silently ignored in status inference
Medium Severity
inferOtelSpanStatusFromAttributes only checks typeof grpcCodeAttribute === 'string', but the OTel semantic convention defines rpc.grpc.status_code as an integer. Numeric gRPC error codes (the common case from instrumentation libraries) fall through to undefined, causing the caller to default to SPAN_STATUS_OK — even for actual gRPC errors like UNKNOWN (2) or INTERNAL (13). Additionally, a string '0' (gRPC OK) would incorrectly map to SPAN_STATUS_ERROR since GRPC_STATUS_CODE_MAP has no entry for '0', yielding 'unknown_error'. The HTTP code path correctly handles both number and string types; the gRPC path needs the same treatment plus a guard for code 0.
Reviewed by Cursor Bugbot for commit a44215e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP