fix(debugging): Clarify debug attach PID mode#430
Merged
Conversation
Document the valid debug_attach_sim attach modes in the public schema and reject pid attach calls that set waitFor to true before invoking LLDB. Fixes #417 Co-Authored-By: OpenAI Codex <noreply@openai.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the valid
debug_attach_simattach modes so MCP clients can avoid invalid PID attach calls.The tool already supported PID attach, but the public schema did not make it clear that
bundleIdandpidare mutually exclusive or thatwaitForonly applies to bundle-id attach. This updates the field descriptions and rejectspid+waitFor: trueduring parameter validation before LLDB is invoked.This keeps the PID attach path explicit for agents trying to connect to an already-running simulator process without restarting the app.
Fixes #417