Keep the thread panel host mounted across thread navigation - #2277
Closed
vburojevic wants to merge 1 commit into
Closed
Keep the thread panel host mounted across thread navigation#2277vburojevic wants to merge 1 commit into
vburojevic wants to merge 1 commit into
Conversation
Thread-to-thread navigation remounted the SecondaryPanelLayout
PanelGroup because the group key defaulted to resetKey (the thread id).
On desktop-inline layouts that destroyed and rebuilt the realized
secondary panel (diff views, metadata, browser deck) in one synchronous
commit per navigate, and reset the user's panel sizes every time.
Pass the documented panelGroupKey escape hatch (already used by
PluginPanelRightPanelHost) so the physical host survives navigation
while content identity still resets via resetKey.
Scope, stated plainly: this is a desktop-inline improvement. On compact
viewports the drawer already rendered outside the keyed group, and the
timeline/composer remount cost on any viewport is owned by PageShell's
own key={threadId} inside EmbeddedThreadChat — unchanged here.
Per-thread state stays correct: drafts and scroll anchors live under
that PageShell key, split layouts are keyed by thread id, and the
hasPanelExpandedRef mount-collapse guard now re-arms per thread since
the Panel instance survives navigation.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SawyerHood
added a commit
that referenced
this pull request
Aug 22, 2026
…ttach edge (#2300) Lands five mobile-performance PRs by Vedran Burojevic plus one follow-up fix. * #2277 Keep the thread panel host mounted across thread navigation * #2278 Gate the default focus refetch on lost realtime coverage * #2279 Apply urgent realtime thread changes without flushing the debounce buffer * #2280 Cache max scroll offset outside the timeline scroll hot path * #2281 Make the published plugin composer host stable across keystrokes Follow-up fix: a detached timeline viewport that a content shrink clamps onto the new, smaller maximum stayed detached, because the clamp's scroll event outruns the ResizeObserver refresh and is classified against the stale cache. The ResizeObserver path now detects that case and re-attaches. Regression test fails on the #2280 head and passes here. Verified: typecheck pass; oxlint 0 errors; @bb/app 422 files / 3,288 tests pass. Merge commits are disabled on this repository, so this squash carries the work of all five branches; co-author trailers preserve authorship. Co-Authored-By: Vedran Burojevic <vedran.burojevic@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
Shipped in #2300 (squash commit 836e216). This branch's changes are on Closing as superseded rather than merged only because merge commits are disabled on this repo: a squash creates a new commit, so GitHub cannot mark this PR merged even though its changes are in Review notes: no regression found. The Thanks — nice work on this batch.
|
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Thread-to-thread navigation remounted the SecondaryPanelLayout PanelGroup (group key defaulted to resetKey = thread id): the realized secondary panel (diff, metadata, browser deck) was destroyed and rebuilt per navigate on desktop-inline layouts, and panel sizes reset every time.
What changed
Pass the documented
panelGroupKeyescape hatch (same pattern as PluginPanelRightPanelHost) so the physical host survives navigation while content identity resets via resetKey. ThehasPanelExpandedRefmount-collapse guard now re-arms per thread since the Panel instance survives.Scope, stated plainly
Desktop-inline improvement. On compact viewports the drawer already rendered outside the keyed group; the timeline/composer remount on any viewport is owned by PageShell's own key={threadId} (unchanged here). Drafts and scroll anchors live under that key, so nothing leaks between threads.
How verified
Regression test (panel subtree DOM identity preserved across threadId change) fails without the fix, passes with it; typecheck + oxlint clean; adversarially reviewed before submission.
🤖 Generated with Claude Code