Add runtime slots for plugin skills - #2262
Open
brsbl wants to merge 3 commits into
Open
Conversation
ymichael
added a commit
that referenced
this pull request
Aug 21, 2026
## What was wrong `MachinesSettingsSection` loads host rows and sidebar project metadata through independent asynchronous queries. The test waited only for `MacBook Pro` from `sdk.hosts.list`, then synchronously queried for `2 projects` from the still-independent sidebar bootstrap. When the host query won that race, the rendered row still showed `0 projects`, producing the same `TestingLibraryElementError` in [PR #2262's app-1 job](https://github.com/get-bb/bb/actions/runs/32530493567) and [PR #2263's app-1 job](https://github.com/get-bb/bb/actions/runs/32530498050). ## What changed The project-count assertion now uses awaited `findByText`, synchronizing the test with the sidebar query that owns the value. The following `1 project` assertion remains synchronous because both counts are derived from the same resolved sidebar payload. No product behavior, assertion coverage, wire contract, CLI, or documentation surface changed. ## How you verified - Reproduced the exact failure before the fix by temporarily delaying only the sidebar response by 50 ms: the host row rendered with `0 projects`, and the test failed at the `2 projects` assertion. With the assertion fix under the same forced ordering, the test passed. The temporary delay is not committed. - `pnpm exec turbo run test --filter=@bb/app --force -- --run src/components/settings/MachinesSettingsSection.test.tsx` — 12/12 passed. - `pnpm exec turbo run test --filter=@bb/app --force` — 418 files passed; 3,244 tests passed and 3 skipped. - `pnpm exec turbo run typecheck --filter=@bb/app --force` — clean. - `pnpm exec turbo run build --filter=@bb/app --force` — clean. - `git diff --check` — clean. Fixes # — no linked issue. BB-Thread-ID: thr_qarynse2fs > AGENT GENERATED: by GPT-5.6-Sol
brsbl
force-pushed
the
bb/plugin-runtime-skill-slots-thr_eibej5m9xw
branch
from
August 22, 2026 07:09
7177f8b to
7f85d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Conditional plugin configuration could select a static skill only by string name, so live plugin settings could not populate predefined content inside that skill without rewriting installed plugin files or falling back to unrelated session instructions.
What changed
PluginAgentConfiguration.skillsasstring[]and add optional experimentalexperimental_skillSlots, keyed by selected skill and declared slot name.PLUGIN_SDK_VERSIONunchanged at0.4.14; no shipped field is renamed, narrowed, restamped, or relabeled.How you verified
v22.22.1arm64 with Turbo typechecks for@bb/serverand@get-bb/plugin-sdk(6/6 tasks).git diff --check 058027f527333ad9b9cd3e0077443bd2a1c26257..7f85d7d45a392dde5cc4dbd282fe9976bbf7c303.Fixes # — no linked issue.
BB-Thread-ID: thr_eibej5m9xw