Add plugin section icons and sidebar actions - #2261
Open
brsbl wants to merge 10 commits into
Open
Conversation
…ns-actions-thr_eibej5m9xw
…ns-actions-thr_eibej5m9xw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Plugins could not express thread-section presentation or native header actions through supported app and SDK boundaries. Section icons were not persisted or returned by the public API, and a plugin action could not ask Core to require an intentional primary-modifier activation, so consumers either duplicated sidebar UI or accepted accidental clicks.
What changed
bb thread sectionCLI flags.experimental_requiresPrimaryModifierregistration flag. Core keeps plain click inert for opted-in actions and accepts Command/Ctrl-click plus Command/Ctrl+Enter/Space.PLUGIN_SDK_VERSIONunchanged at0.4.14; this layer does not restamp or relabel an existing SDK release.Before — exact merge base
f54b2f84bAfter — exact head
058027f52How you verified
v22.22.1arm64 with Turbo typechecks for@bb/app,@get-bb/plugin-sdk, and@bb/server(7/7 tasks).git diff --check f54b2f84be86ea23449031cf9614170c929a9b91..058027f527333ad9b9cd3e0077443bd2a1c26257.Delivery/Release checklistfixture,/route, open Delivery actions menu, and 1224×768 native window bounds.Fixes # — no linked issue.
BB-Thread-ID: thr_eibej5m9xw