fix(selectivity): anonymous styles#1276
Merged
Merged
Conversation
commit: |
KuznetsovRoman
commented
Jun 10, 2026
|
|
||
| let sourceMapResolvedUrl = urlResolve(sourceURL, sourceMapURL); | ||
|
|
||
| if (!URL.canParse(sourceMapResolvedUrl)) { |
Member
Author
There was a problem hiding this comment.
Instead of checking "is there any base url" we see "if it resolved to valid url" (no source url + embedded sourcemap = valid)
|
|
||
| if (this._scriptsSource[scriptId] && this._scriptsSourceMap[scriptId]) { | ||
| // Anonymous or processed | ||
| if (!url || (this._scriptsSource[scriptId] && this._scriptsSourceMap[scriptId])) { |
Member
Author
There was a problem hiding this comment.
If script is anonymous, dont set "null" to scripts map so it would not be considered as "handled" and would be processed if needed, on "stop" call if this script explicitly was in the coverage
KuznetsovRoman
force-pushed
the
TESTPLANE-1040.anonymous_styles
branch
from
8a866f2 to
a3eca39
Compare
KuznetsovRoman
changed the title
sonic16x
approved these changes
Jun 11, 2026
KuznetsovRoman
commented
Jun 11, 2026
| "homepage": "https://testplane.io/", | ||
| "engines": { | ||
| "node": ">= 18.0.0" | ||
| "node": ">= 18.17.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.