feat!: add async function config support#1273
Merged
Merged
Conversation
KuznetsovRoman
commented
Jun 4, 2026
|
|
||
| const configPath = preparseOption(program, "config") as string; | ||
| testplane = Testplane.create(configPath); | ||
| testplane = await Testplane.create(configPath); |
Member
Author
There was a problem hiding this comment.
Testplane.create is now async, because config is parsed inside of it
| const installBrowsers_ = async (argv: string = ""): Promise<void> => { | ||
| process.argv = ["foo/bar/node", "foo/bar/script", "install-deps", ...argv.split(" ")].filter(Boolean); | ||
| cli.run(); | ||
| await cli.run(); |
Member
Author
There was a problem hiding this comment.
cli.run was always async
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
KuznetsovRoman
force-pushed
the
TESTPLANE-178.config_async
branch
from
d7cc930 to
497c7c2
Compare
commit: |
sonic16x
approved these changes
Jun 7, 2026
KuznetsovRoman
force-pushed
the
TESTPLANE-178.config_async
branch
from
497c7c2 to
8fc9934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.