Refresh README to match current API surface and NDK asset model#5
Merged
Conversation
Agent-Logs-Url: https://github.com/fulvius31/WpsConnectionLibrary/sessions/70a4bc67-fe4f-43e1-a9e9-86d1629028f2 Co-authored-by: fulvius31 <18355812+fulvius31@users.noreply.github.com>
Agent-Logs-Url: https://github.com/fulvius31/WpsConnectionLibrary/sessions/70a4bc67-fe4f-43e1-a9e9-86d1629028f2 Co-authored-by: fulvius31 <18355812+fulvius31@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update README file with additional information
Refresh README to match current API surface and NDK asset model
Mar 31, 2026
fulvius31
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README was out of sync with the current library behavior and integration surface. This update aligns public documentation with the actual constructor/API signatures, callback/model fields, and post-NDK asset requirements.
API usage/docs alignment
WpsConnectionManagerexamples/signatures to the current constructor:WpsConnectionManager(Context context)WpsLibConfigusage from README examples.Callback + model documentation updates
onPixieDustSuccess(String pin, String password, String wpsExchangeLog)wpsExchangeLogtoNetworkToTestdocs and clarified null behavior/propagation to callback parameter.Platform/ABI documentation
armeabi-v7a,arm64-v8a,x86_64.x86(32-bit Intel) is not included.Required assets section (NDK migration)
pin.dbmust be provided in app assets.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant(dns block)If you need me to access, download, or install something from one of these locations, you can either: