Skip to content

Fix ls detail default #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shcheklein merged 1 commit into from
Aug 6, 2026
Merged

Fix ls detail default #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sshfs/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ async def _cp_file(self, lpath, rpath, **kwargs):
await self._execute(cmd)

@wrap_exceptions
async def _ls(self, path, detail=False, **kwargs):
async def _ls(self, path, detail=True, **kwargs):
async with self._pool.get() as channel:
file_attrs = await channel.readdir(path)

Expand Down
6 changes: 3 additions & 3 deletions tests/test_sshfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def test_sftp_client_kwargs_path_encoding(
(directory / "data.txt").write_bytes(b"data")

encoded = str(directory).encode()
assert fs.ls(encoded) == [encoded + b"/data.txt"]
assert fs.ls(encoded, detail=False) == [encoded + b"/data.txt"]
assert fs.cat_file(encoded + b"/data.txt") == b"data"


Expand Down Expand Up @@ -247,9 +247,9 @@ def test_ls(fs, remote_dir):
fs.touch(file)
files.add(file)

assert set(fs.ls(remote_dir + "dir/")) == files
assert set(fs.ls(remote_dir + "dir/", detail=False)) == files

dirs = fs.ls(remote_dir + "dir/", detail=True)
dirs = fs.ls(remote_dir + "dir/")
expected = [fs.info(file) for file in files]

by_name = lambda details: details["name"]
Expand Down
Loading