[repo-assist] perf: use HashSet for culture-code lookup in processFolder - #1241
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[repo-assist] perf: use HashSet for culture-code lookup in processFolder#1241github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Replace Array.distinct + Array.contains (O(n)) with HashSet<string> (O(1)) for the per-directory language-code check in processFolder. On a site with many nested directories this check was called for every directory traversed. With the previous Array.contains the cost grew linearly with the number of supported culture codes (~800). HashSet.Contains makes each check O(1). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Replace
Array.distinct+Array.contains(O(n)) withHashSet<string>(O(1)) for the per-directory language-code check inprocessFolder.Details
In
DocContent.processFolder, every directory traversed checks whether its two-letter name is a known culture code to decide if it is an "other language" subdirectory:With ~800 culture codes in
CultureTypes.AllCultures, eachArray.containscall scans up to 800 strings. On a large docs site with many nested directories this adds up.The
Array.distinctstep is also removed becauseHashSetdeduplicates automatically.Test Status
dotnet build src/fsdocs-tool/fsdocs-tool.fsproj --configuration Release— passeddotnet fantomas src/fsdocs-tool/BuildCommand.fs --check— no formatting changes requiredAdd this agentic workflow to your repo
To install this agentic workflow, run