docs: remove the internal E2E review from the public site (FR-26112) - #124
Merged
Merged
Conversation
docs/E2E_REACT_NATIVE_TESTS_REVIEW.md reviewed the test suites in the internal e2e-system-tests repository, including its layout and coverage gaps. Docsify serves the docs directory, so it was reachable on the published guide. Five references pointed at it - two in example/E2E_TESTS.md and three in androidTest comments citing its section numbers. Each now states the point directly rather than citing a document that no longer exists. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An internal test review was published on the docs site
docs/E2E_REACT_NATIVE_TESTS_REVIEW.mdreviewed the React Native suites in the internalfrontegg/e2e-system-testsrepository — its directory layout, its coverage gaps, and recommendations for closing them. Docsify serves thedocsdirectory, so it was reachable on the published guide.Its references were repointed, not orphaned
Five places cited it, and a plain delete would have left every one dangling:
example/E2E_TESTS.md— a link, plus a citation of§5.3for the shared test-ID conventionPasskeysLoginTest.kt—§4PasskeysRegisterTest.kt—§4RefreshTokenTest.kt—§5.4Each now states its point directly — "new coverage for passkey registration" rather than "gap flagged in
…§4" — so the comments still explain why the test exists without depending on a document that is gone. Verified no references remain.Note: this removes the file from the tip of the branch, not from git history.
🤖 Generated with Claude Code