feat: regenerate client from corrected OpenAPI spec#3
Merged
Conversation
regenerated the java client from the spec produced by frain-dev/convoy#2742, which fixes nullable object/map handling, the bearer auth security scheme, json-only onboard, and portal link endpoints_metadata nullability.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cdccbe2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
endpoints_metadatanullability).Test plan
Note
Medium Risk
Large generated surface area and a breaking change to bulk onboard request typing; behavior shifts around null/optional JSON fields across many models.
Overview
Regenerates the Java client from the updated Convoy OpenAPI spec, with a post-generation perl step in
generate.shthat fixesJsonNullablemap helpers soput*Itemdoes not NPE aftersetX(null)or JSONnull.Model changes are dominated by optional fields moving to
JsonNullable(getters,*_JsonNullablesetters, and nullable-awareequals/hashCode), plusEMPTYsentinel values on generated enums for open/null enum cases.OnboardApi.bulkOnboardis a notable API break: the JSON body parameter is nowModelsBulkOnboardRequest(serialized asapplication/json) instead of aFilewithapplication/octet-stream.Reviewed by Cursor Bugbot for commit cdccbe2. Bugbot is set up for automated code reviews on this repo. Configure here.