Skip to content

only display options list if not empty#112

Open
magalhas wants to merge 3 commits into
fmoo:masterfrom
magalhas:empty-ul
Open

only display options list if not empty#112
magalhas wants to merge 3 commits into
fmoo:masterfrom
magalhas:empty-ul

Conversation

@magalhas

@magalhas magalhas commented Aug 3, 2015

Copy link
Copy Markdown

When there were no visible items the

    was being rendered without need.

@fmoo

fmoo commented Aug 3, 2015

Copy link
Copy Markdown
Owner

I haven't read through the rest of the code lately, but does this break anything that assumes "sel" is a valid reference anywhere else?

@magalhas

magalhas commented Aug 3, 2015

Copy link
Copy Markdown
Author

From my experience it's not throwing any errors, but yeah the ref won't be available with this if statement.

I wanted to put this logic inside the List component, though you can't return undefined / null on a render method.

@magalhas

Copy link
Copy Markdown
Author

It would be awesome if this could be included so that we can stop using our fork git dependency.

@fmoo

fmoo commented Mar 10, 2016

Copy link
Copy Markdown
Owner

Can you rebase and move the logic into _shouldSkipSearch() ?

@magalhas

Copy link
Copy Markdown
Author

@fmoo done.

@fmoo

fmoo commented Mar 11, 2016

Copy link
Copy Markdown
Owner

Hey, we've had a couple of regressions lately, would you mind including a unit test for this as well?

@magalhas

Copy link
Copy Markdown
Author

Sure, not sure when I'll be able to pick this up though. What about my other 2 PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants