[camera_android_camerax] Update AGENTS.md to improve video recording integration tests - #12301
Open
camsim99 wants to merge 2 commits into
Open
[camera_android_camerax] Update AGENTS.md to improve video recording integration tests#12301camsim99 wants to merge 2 commits into
AGENTS.md to improve video recording integration tests#12301camsim99 wants to merge 2 commits into
Conversation
camsim99
changed the title
AGENTS.md to improve video recording integration tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AGENTS.md file in packages/camera/camera_android_camerax to add a guideline requiring a delay during video recording integration tests to prevent flakiness. There are no review comments, and there is no feedback to provide.
11 tasks
reidbaker
approved these changes
Jul 28, 2026
| - Maintain high test coverage using [dart-add-unit-test](.agents/skills/dart-add-unit-test/SKILL.md) | ||
| and [dart-collect-coverage](.agents/skills/dart-collect-coverage/SKILL.md). | ||
| - Avoid duplicating constant strings; reuse existing ones from adjacent code. | ||
| - **Video Recording Integration Tests**: You MUST insert a delay (e.g., `await Future<void>.delayed(const Duration(seconds: 4));`) after starting a video recording and before stopping it. Without this delay, the test will flake or fail because the Android device/emulator needs time to initialize the encoder and capture frames before finalizing. |
Contributor
There was a problem hiding this comment.
non blocking nits. I think this should break out into a TESTING.md that documents our testing best practices and rules and tips like this.
| - Maintain high test coverage using [dart-add-unit-test](.agents/skills/dart-add-unit-test/SKILL.md) | ||
| and [dart-collect-coverage](.agents/skills/dart-collect-coverage/SKILL.md). | ||
| - Avoid duplicating constant strings; reuse existing ones from adjacent code. | ||
| - **Video Recording Integration Tests**: You MUST insert a delay (e.g., `await Future<void>.delayed(const Duration(seconds: 4));`) after starting a video recording and before stopping it. Without this delay, the test will flake or fail because the Android device/emulator needs time to initialize the encoder and capture frames before finalizing. |
Contributor
There was a problem hiding this comment.
Can we link to a test that does this correctly?
camsim99
added
override: no versioning needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds note to
AGENTS.mdto hint to agents that if they add integration tests for video recording, they should add a delay between starting/stopping recordings to ensure the camera has enough time to initialized and get a valid recording.Inspired by an agent running into this while creating #12145 (see #12145 (comment))
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2