Skip to content

Remove unused code from test/ - #9918

Open
kenzieschmoll wants to merge 9 commits into
flutter:masterfrom
kenzieschmoll:dcm-test
Open

Remove unused code from test/#9918
kenzieschmoll wants to merge 9 commits into
flutter:masterfrom
kenzieschmoll:dcm-test

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

Work towards #9906

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive cleanup of the test infrastructure by removing a significant amount of unused code, including deleted test files, unused helper functions, dead variables, and obsolete imports. The review feedback suggests fully removing the afterNewSetup and beforeFinalTearDown lifecycle hooks in FlutterTestEnvironment instead of suppressing the unused-code warnings, since the tests that relied on them have been removed.

Comment thread packages/devtools_app/test/test_infra/flutter_test_environment.dart Outdated
Comment thread packages/devtools_app/test/test_infra/flutter_test_environment.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants