Skip to content

Remove unused code in integration_test and shared - #9916

Open
kenzieschmoll wants to merge 24 commits into
flutter:masterfrom
kenzieschmoll:dcm-3
Open

Remove unused code in integration_test and shared#9916
kenzieschmoll wants to merge 24 commits into
flutter:masterfrom
kenzieschmoll:dcm-3

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

Work towards #9906

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a large-scale cleanup of unused code, deprecated preferences, and redundant helper methods across the DevTools codebase. It also introduces a prettyPrint() extension on Object? to replace various inline usages of JsonEncoder.withIndent. A concern was raised regarding this extension, as defining it on Object? pollutes the autocomplete namespace for all types and reduces type safety. It is recommended to use a top-level helper function instead.

Comment thread packages/devtools_app/lib/src/shared/primitives/utils.dart Outdated

@srawlins srawlins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants