[webview_flutter_lwe] Remove Ecore API#1046
Open
JSUYA wants to merge 1 commit into
Open
Conversation
JSUYA
force-pushed
the
remove-ecore-webview-flutter-lwe
branch
from
c95d46b to
7e115e7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the webview_flutter_lwe package to version 0.4.1, replacing the Ecore API with GLib's g_idle_add_full for main thread task dispatching in message_dispatcher.cc. Feedback recommends using the GDestroyNotify callback of g_idle_add_full to safely deallocate the Param struct, ensuring memory is freed even if the idle source is removed before execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Replace Ecore main-loop dispatch with g_idle_add_full in MessageDispatcher.
JSUYA
force-pushed
the
remove-ecore-webview-flutter-lwe
branch
from
7e115e7 to
b14cb60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Ecore main-loop dispatch with g_idle_add_full in MessageDispatcher.