feat(spm): complete iOS SPM migration — remove all podspecs, use arrrrny/google-mlkit-swiftpm#880
Closed
arrrrny wants to merge 22 commits into
Closed
feat(spm): complete iOS SPM migration — remove all podspecs, use arrrrny/google-mlkit-swiftpm#880arrrrny wants to merge 22 commits into
arrrrny wants to merge 22 commits into
Conversation
… update gitignore
…ir name for local path deps)
…tion with explanatory comment
…d build phase to replace SPM thin wrapper
…n model dylib + build script
…rny/google-mlkit-swiftpm - Delete all 22 CocoaPods podspecs across all packages - Update all 11 Package.swift files to reference arrrrny/google-mlkit-swiftpm - Add per-language OCR resource bundles (Latin, Chinese, Japanese, Korean, Devanagari) - Set -ObjC linker flag in example apps for ObjC category support - Create focused text_recognition_example app - Update Package.resolved files for SPM consistency - Clean up stale CocoaPods artifacts and build caches - Fixes text recognition 'Invalid model path' crash (d-date#106) - Fixes dyld flat-namespace crash on TestFlight/Release builds
Author
Author
…en 9.0.0-1 tag The 9.0.0-1 tag on arrrrny/google-mlkit-swiftpm points to an old commit with duplicate binary target entries. Use the fixed commit directly.
|
Would love to get this landed. Because after upgrading from old mac to fresh I can't use that lib anymore. Latest error when use develop branch: Failed to build iOS app |
Collaborator
|
@arrrrny : make the PR against this branch: https://github.com/flutter-ml/google_ml_kit_flutter/commits/feature/spm/ |
Collaborator
|
is this replaced by #881? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the iOS SPM migration by removing all CocoaPods podspecs and transitioning every plugin to pure Swift Package Manager, backed by
arrrrny/google-mlkit-swiftpm(release9.0.0-1).Changes
Core migration
.podspecfiles — no more CocoaPods for any pluginPackage.swiftfiles — all ML Kit plugins now referencearrrrny/google-mlkit-swiftpminstead ofd-date/google-mlkit-swiftpmPackage.resolvedfiles in example appsText recognition fixes (d-date/google-mlkit-swiftpm#106)
MLKitTextRecognitionResources.bundlewith 5 per-language OCR bundles: Latin, Chinese, Japanese, Korean, Devanagari-ObjClinker flag added to prevent Objective-C category stripping (fixesunrecognized selectorcrashes inMLKitCommon)Build infrastructure
.gitignoreupdated for SPM build artifacts (**/.build/,**/.swiftpm/, per-packagePackage.resolved)MLKitTextRecognitionCommon.full.dylib.gz,.builddirectories, oldPackage.resolvedfilesNew example app
packages/text_recognition_example/— minimal focused example that generates a test image with Latin text and runs ML Kit OCR, verifying the full pipeline end-to-endRoot causes fixed
.aarchive (viaalex-pan-invos's textfix5 → now self-hosted on arrrrny)unrecognized selectorcrash — Objective-C categories in MLKitCommon stripped by linker. Fixed by adding-ObjC/-all_loadlinker flagsLatinOCRResources.bundlemust be in main app bundle (sincebundleForClass:returns main bundle with static linking). Fixed by adding bundles to app target's Copy Bundle ResourcesTesting