Detect circular self-resolution instead of StackOverflowError#423
Open
muhammadkamel wants to merge 2 commits into
Open
Detect circular self-resolution instead of StackOverflowError#423muhammadkamel wants to merge 2 commits into
muhammadkamel wants to merge 2 commits into
Conversation
Fail fast with a StateError when a factory re-enters the same registration (e.g. registerLazySingleton<Iface>(getIt.call)), and only interpolate the catch stack when debug output is enabled.
Clear the creation-in-progress guard when the factory returns its Future, not when that Future completes, so overlapping always-new/cached async resolutions are not treated as circular self-resolution.
Author
|
Follow-up: fixed a Bugbot finding where overlapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerLazySingleton<Iface>(getIt.call)/ untyped tear-offs) and throw a clearStateErrorinstead of overflowing the stack.$stackTraceinterpolation in creation-error debug logging whenGetIt.noDebugOutputis set (that path can make release crash dumps look "native").() => getIt<Impl>()).Motivation
In production, registering an untyped tear-off of
call/getas a factory for interfaceTrecursively callsget<T>()untilStackOverflowError. Some crash reporters then drown inStackTrace.toStringwork, which obscured the real DI bug.Test plan
dart test test/circular_self_resolution_test.dartdart test(full suite)() => getIt<Impl>()/ named tear-offs