Encode BPMN XSD URL so schema validation works on non-ASCII paths - #4262
Open
kalayciburak wants to merge 1 commit into
Open
Encode BPMN XSD URL so schema validation works on non-ASCII paths#4262kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
Fixes flowable#4214 Xerces cannot resolve xsd:include/import when ClassLoader.getResource returns a URL whose path contains non-ASCII characters. Encode the schema URL with URI.toASCIIString() before SchemaFactory.newSchema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
Fixes #4214
BpmnXMLConverter.createSchemapassedClassLoader.getResourceURLsstraight to
SchemaFactory.newSchema. When the Flowable jar lives on apath with non-ASCII characters (for example an unpacked Spring Boot
classpath), Xerces fails to resolve
xsd:include/xsd:importwithsrc-resolve: Cannot resolve the name 'extension'.The schema URL is now ASCII-encoded via
URI.toASCIIString()beforeloading. Relative includes keep working.
Test Plan
NonAsciiClasspathSchemaValidationTestfailed with the reportedsrc-resolveerror before the change, then passedChineseConverterTest2/2mvn -pl modules/flowable-bpmn-converter -am test192/192 inflowable-bpmn-converter