Skip to content

fix(ci): unblock releases from TypeScript 7 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fiona2016 merged 4 commits into from
Aug 7, 2026
Merged

fix(ci): unblock releases from TypeScript 7 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d231223
fix(ci): unblock releases from TypeScript 7
Fiona2016 Aug 7, 2026
14b35f3
fix(ci): migrate the lockfile to the format the new yarn writes
Fiona2016 Aug 7, 2026
14aa6f5
fix(ci): keep the yarn upgrade to the yarn path
Fiona2016 Aug 7, 2026
59b0a3a
fix(ci): let package install scripts run again
Fiona2016 Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
944 changes: 944 additions & 0 deletions .yarn/releases/yarn-4.17.1.cjs
View file
Open in desktop

Large diffs are not rendered by default.

948 changes: 0 additions & 948 deletions .yarn/releases/yarn-4.9.1.cjs
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
yarnPath: .yarn/releases/yarn-4.9.1.cjs
yarnPath: .yarn/releases/yarn-4.17.1.cjs
defaultSemverRangePrefix: ''
nodeLinker: node-modules

# Yarn 4.17 stopped running package install scripts by default, where 4.9 ran them. The e2e suite
# depends on one: puppeteer downloads the Chrome it drives from its own install script, and without
# it the suite fails looking for a browser that was never fetched. This keeps the behaviour the
# repository already had — turning it off is a change of its own, with its own fallout to handle.
enableScripts: true

# Gitlab artifacts are only supported folders relative to the repository. Disable global cache so yarn will store the cache in .yarn/cache.
# See https://docs.gitlab.com/ee/ci/jobs/job_artifacts.html#create-job-artifacts
# See https://yarnpkg.com/configuration/yarnrc#enableGlobalCache
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,5 @@
"node": "23.11.1",
"yarn": "1.22.22"
},
"packageManager": "yarn@4.9.1"
"packageManager": "yarn@4.17.1"
}
18 changes: 15 additions & 3 deletions scripts/check-typescript-compatibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ runMain(() => {
command`yarn install --no-immutable`.withCurrentWorkingDirectory(TEST_APP_DIR).run()
const testAppSnapshot = snapshotFiles(TEST_APP_MUTATED_FILES)

// TypeScript 7 removed `target: es5` and `moduleResolution: node10`, the two options the test
// app's tsconfig is built on. A consumer on a current TypeScript cannot express that
// configuration at all, so checking our type definitions against it there would be checking a
// setup nobody can have. These are what such a consumer uses instead, and what this app already
// is — a bundler-resolved web app — at the oldest target still available, which keeps the point
// of the older checks: that the definitions survive a low target.
const currentTypeScriptOptions = {
target: 'es2015',
module: 'preserve',
moduleResolution: 'bundler',
}

const checks = [
{
title: 'TypeScript 3.8.2 compatibility',
Expand All @@ -35,18 +47,18 @@ runMain(() => {
},
{
title: 'TypeScript latest compatibility',
compilerOptions: { ignoreDeprecations: '6.0' },
compilerOptions: currentTypeScriptOptions,
version: 'latest',
},
{
title: 'exactOptionalPropertyTypes compatibility',
version: 'latest', // Not available in 3.8.2
compilerOptions: { exactOptionalPropertyTypes: true, ignoreDeprecations: '6.0' },
compilerOptions: { ...currentTypeScriptOptions, exactOptionalPropertyTypes: true },
},
{
title: 'ESNext compatibility',
version: 'latest',
compilerOptions: { ignoreDeprecations: '6.0', lib: ['ESNext', 'DOM'] },
compilerOptions: { ...currentTypeScriptOptions, lib: ['ESNext', 'DOM'] },
},
]

Expand Down
18 changes: 9 additions & 9 deletions test/apps/vanilla/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,42 +2,42 @@
# Manual changes might be lost - proceed with caution!

__metadata:
version: 8
version: 10
cacheKey: 10c0

"@flashcatcloud/browser-core@file:../../../packages/core/package.tgz::locator=app%40workspace%3A.":
version: 0.0.6
resolution: "@flashcatcloud/browser-core@file:../../../packages/core/package.tgz#../../../packages/core/package.tgz::hash=f3b706&locator=app%40workspace%3A."
checksum: 10c0/4e69360f7af625fb3a8673678dde06618b141d60fe7f704ff72fc16f9a365602c5db10339487b7e9bc379df99504fc4557e2361b3d648e10f4f363580b7f2f01
resolution: "@flashcatcloud/browser-core@file:../../../packages/core/package.tgz#../../../packages/core/package.tgz::hash=e964b0&locator=app%40workspace%3A."
checksum: 10c0/616d303942c7549333b68957abb50ac9c8fd6c3098fa821d13510b0279f983b58e162f315a3377209877ff66646881ec696b4f852e4541fa2437f4b9fca3197f
languageName: node
linkType: hard

"@flashcatcloud/browser-logs@file:../../../packages/logs/package.tgz::locator=app%40workspace%3A.":
version: 0.0.6
resolution: "@flashcatcloud/browser-logs@file:../../../packages/logs/package.tgz#../../../packages/logs/package.tgz::hash=116f97&locator=app%40workspace%3A."
resolution: "@flashcatcloud/browser-logs@file:../../../packages/logs/package.tgz#../../../packages/logs/package.tgz::hash=4e8e68&locator=app%40workspace%3A."
dependencies:
"@flashcatcloud/browser-core": "npm:0.0.6"
peerDependencies:
"@flashcatcloud/browser-rum": 0.0.6
peerDependenciesMeta:
"@flashcatcloud/browser-rum":
optional: true
checksum: 10c0/f1226b89f74f9c3b3d010519788455ca935d9a216ac20a178093d240686d5f56f9b58ec67a7cb53f8ca4e1975b56085b8be39835a0cd209a478d3a92cc7fb960
checksum: 10c0/ca959af9037037a092d76a881d00ead45ded1c050619b0e77542d3fd4c5863ec10a00ab50ede4895aaf2c3ce5d7cdfce949f80d81a971a533ce8b0e32253a545
languageName: node
linkType: hard

"@flashcatcloud/browser-rum-core@file:../../../packages/rum-core/package.tgz::locator=app%40workspace%3A.":
version: 0.0.6
resolution: "@flashcatcloud/browser-rum-core@file:../../../packages/rum-core/package.tgz#../../../packages/rum-core/package.tgz::hash=ddfe11&locator=app%40workspace%3A."
resolution: "@flashcatcloud/browser-rum-core@file:../../../packages/rum-core/package.tgz#../../../packages/rum-core/package.tgz::hash=01e814&locator=app%40workspace%3A."
dependencies:
"@flashcatcloud/browser-core": "npm:0.0.6"
checksum: 10c0/7f5deaedbd174d249fd6dc197c60522df93330d15534f5690d9ad6982c2901059a58f6cbdc3835ec8529f0fbbe80cc04ccae4a22e38f8bd97011c58a06accbee
checksum: 10c0/5b2f9413a2ed3a1028e843d191a1d578529752e5126c09d9438fa5081bae629dc1ec4f82e692a777769bd3ae1c64c51b8d53fdd963b82f641b6369118afafc7d
languageName: node
linkType: hard

"@flashcatcloud/browser-rum@file:../../../packages/rum/package.tgz::locator=app%40workspace%3A.":
version: 0.0.6
resolution: "@flashcatcloud/browser-rum@file:../../../packages/rum/package.tgz#../../../packages/rum/package.tgz::hash=380466&locator=app%40workspace%3A."
resolution: "@flashcatcloud/browser-rum@file:../../../packages/rum/package.tgz#../../../packages/rum/package.tgz::hash=1a204b&locator=app%40workspace%3A."
dependencies:
"@flashcatcloud/browser-core": "npm:0.0.6"
"@flashcatcloud/browser-rum-core": "npm:0.0.6"
Expand All @@ -46,7 +46,7 @@ __metadata:
peerDependenciesMeta:
"@flashcatcloud/browser-logs":
optional: true
checksum: 10c0/6c868624f69dedb98da27dfa0e26fba0cc53d425d3578054db36373565d7a7ce4d2f0e49eae9afb6d106a2a5790bfe4a7e0bae268b28f42c9aa2f15ffbf92ae3
checksum: 10c0/42902dccde0b7788d258b5939b1e431804598b2c4502d06f41e10bfaacdde6a78a8abd206425be31d4ab13321c84ba1102f236c3fde5f7dc11b498d60feb3fed
languageName: node
linkType: hard

Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Manual changes might be lost - proceed with caution!

__metadata:
version: 8
version: 10
cacheKey: 10c0

"@alicloud/cdn20180510@npm:5.0.0":
Expand Down Expand Up @@ -10708,14 +10708,14 @@ __metadata:

"resolve@patch:resolve@npm%3A^1.10.0#optional!builtin<compat/resolve>, resolve@patch:resolve@npm%3A^1.20.0#optional!builtin<compat/resolve>, resolve@patch:resolve@npm%3A^1.22.4#optional!builtin<compat/resolve>":
version: 1.22.10
resolution: "resolve@patch:resolve@npm%3A1.22.10#optional!builtin<compat/resolve>::version=1.22.10&hash=c3c19d"
resolution: "resolve@patch:resolve@npm%3A1.22.10#optional!builtin<compat/resolve>::version=1.22.10&hash=9bd1a5"
dependencies:
is-core-module: "npm:^2.16.0"
path-parse: "npm:^1.0.7"
supports-preserve-symlinks-flag: "npm:^1.0.0"
bin:
resolve: bin/resolve
checksum: 10c0/52a4e505bbfc7925ac8f4cd91fd8c4e096b6a89728b9f46861d3b405ac9a1ccf4dcbf8befb4e89a2e11370dacd0160918163885cbc669369590f2f31f4c58939
checksum: 10c0/da5c4a85971e6eeb821805d117092321c6c257a6e1e45382c0b7ef41368a7e98690e01a08bac88b111443410a49e2fb17d1802ac5c51c8fc5532d77bef9f4be9
languageName: node
linkType: hard

Expand Down
Loading