Use attest repo to compute expected measurements from image hashes#47
Draft
ameba23 wants to merge 8 commits into
Draft
Use attest repo to compute expected measurements from image hashes#47ameba23 wants to merge 8 commits into
ameba23 wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This is a protocol breaking change as it changes the format of the wire message for attestation payload.
This is the first step towards integrating with the easy-tee/attest repo, and is based roughly on @Ruteri 's attest-integration-idea branch.
This adds platform metadata from the to the attestation payload which the attester produces and the verifier checks, and adds a new variant to the
MeasurementRecordenum used by in the measurement policy for verification, which allows image hashes to be specified rather than a full set of measurements.When verifying, if we have a policy which specifies image hashes rather than a full set of measurements, we we compute expected measurements using attest-measure's
expected_dcap_registersfunction based on the platform metadata and image hashes.There are still a lot of things missing from this PR, and currently some very similar types are duplicated between this repo's
attestationcrate andattest-types. There is a little bit of friction there with wanting to maintain compatibility with our current measurement policy JSON format (for the attestation type names) and some things which i just didn't get to yet. But potentially this can become a lot neater, and we can lean more on the functionality in the attest repo.Related issue: #40
Paired PR in
attest: Easy-TEE/attest#12TODO:
attestationandattest. The issue is representing the NoAttestation case. Potentially we can useOption. Also potentially an issue with adding Nitro support in Add experimental support for AWS Nitro #45VersionedAttestationformat. Or at least document that these will not work with 'portable' measurement policies due to the missing platform metadata.expected_dcap_registers.