[backport release-1.21] propagate module context to nelm logs#807
Merged
ldmonster merged 1 commit intoJul 17, 2026
Merged
Conversation
Signed-off-by: diyliv <onlogn081@gmail.com>
ldmonster
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick
d582982("propagate module context to nelm logs") frommaintorelease-1.21.The fix propagates the module name through context to nelm internal log messages, so progress tables, resource tracking, and other nelm internal logs show the correct
modulefield instead of a frozen one from whichever module initialized the singleton first.Changes:
pkg/helm/helm.go— callnelm.InitDefaultLogger(helmopts.Logger)during helm client factory initpkg/helm/nelm/logger.go— addmoduleAttr(ctx)helper, thread it through all log methodspkg/helm/nelm/nelm.go— extractInitDefaultLogger, addcontextWithModule/moduleFromContext, pass module context to all nelm action callspkg/helm/nelm/nelm_test.go— add tests for module-in-context logging and singleton logger behaviorWhy do we need it, and what problem does it solve?
nelm internal log messages (progress tables, resource tracking) print a frozen
modulefield from whichever module initialized the nelm client singleton first. This makes debugging and monitoring unreliable — log messages from nelm operations are attributed to the wrong module.Changelog entries