Create the Network track from the timeline-network schema display location - #6224
Open
fatadel wants to merge 1 commit into
Open
Create the Network track from the timeline-network schema display location#6224fatadel wants to merge 1 commit into
fatadel wants to merge 1 commit into
Conversation
…ation The Network track was added whenever a thread had a marker with data.type === 'Network'. Add a timeline-network marker-schema display location, declare it on the Network schema, and drive track creation from that location so Network handling no longer hardcodes the payload type. The combined (front-end + Gecko) schema list is used so the front-end Network schema override always contributes its timeline-network location. Part of firefox-devtools#6194
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6224 +/- ##
=======================================
Coverage 83.62% 83.62%
=======================================
Files 346 346
Lines 37145 37151 +6
Branches 10311 10313 +2
=======================================
+ Hits 31061 31067 +6
Misses 5656 5656
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
reviewed
Jul 30, 2026
Comment on lines
+119
to
+120
| // This adds markers to the Network track. | ||
| | 'timeline-network' |
Member
There was a problem hiding this comment.
Probably not super important since this is only used in the frontend-only marker schema that we have in this codebase, but since we are adding a new MarkerDisplayLocation, it would be good to add an processed profile upgrader for this (mostly for external profiles)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Profile
The Network track was added whenever a thread had a marker with data.type === 'Network'. Add a timeline-network marker-schema display location, declare it on the Network schema, and drive track creation from that location so Network handling no longer hardcodes the payload type.
The combined (front-end + Gecko) schema list is used so the front-end Network schema override always contributes its timeline-network location.
Part of #6194