Show markers that are in the committed range only in profiler-cli thread markers - #6222
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6222 +/- ##
==========================================
+ Coverage 83.62% 83.63% +0.01%
==========================================
Files 346 346
Lines 37145 37153 +8
Branches 10311 10315 +4
==========================================
+ Hits 31061 31073 +12
+ Misses 5656 5652 -4
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mstange
approved these changes
Jul 27, 2026
The default 'thread markers' read `getFullMarkerListIndexes`, which ignores the committed range, so zooming had no effect unless --search was also passed. Switch the default paths to `getCommittedRangeFilteredMarkerIndexes` so both branches respect the current zoom consistently.
When zoomed into a committed range, the marker count line now reads 'N markers in view (of M in the full range)', mirroring the 'of view / of full' percentages that 'thread samples' already shows. The baseline is this thread's marker count over the full time range (ignoring zoom), exposed as a new optional fullRangeMarkerCount field set only when zoomed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
This fixes #6221 .
It looks like we forgot to filter the markers by the range. It was only working when the
--searchfilter was passed due to the selector that was used for that case. Now it should work for every case.I also updated the text output a bit to make sure that it's understandable that this is only a subset of full range thread markers.
For example:
See
1237 markers in view (of 11715 in the full range).