Skip to content

Use system zlib for build tools#1857

Merged
a-maurice merged 1 commit into
mainfrom
am-build_tools
May 27, 2026
Merged

Use system zlib for build tools#1857
a-maurice merged 1 commit into
mainfrom
am-build_tools

Conversation

@a-maurice
Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

After updating to the newer mac runners, the binutil tool has been failing to build correctly because of the zlib version. The zlib version isn't that important to this use case, so use the system one instead.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/26471027607


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label May 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@a-maurice a-maurice requested a review from cynthiajoan May 26, 2026 20:08
@a-maurice a-maurice merged commit 4863376 into main May 27, 2026
73 of 89 checks passed
@a-maurice a-maurice deleted the am-build_tools branch May 27, 2026 00:21
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label May 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

❌  Integration test FAILED

Requested by @a-maurice on commit 4863376
Last updated: Tue May 26 19:18 PDT 2026
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [Linux] [x64] [openssl]
(2 failed tests)  FirebaseAuthTest.TestUpdateEmailAndPassword
  FirebaseAuthTest.TestVerifyBeforeUpdatingEmail

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label May 27, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants