Core-canonical build convention#11
Merged
Merged
Conversation
Invert the build naming so the canonical protobuf.lua is the CORE build (bitn excluded via -i bitn, expected on the path), composing with libraries that share bitn without duplicating it. protobuf-portable.lua bundles every dependency for drop-in use. CI/release publish both; version smoke-test covers both.
The rolling luajit-2.1 HEAD built by leafo/gh-actions-lua began miscompiling the signed arithmetic-shift edge cases in zigzag encoding (crypto/bthome pass on the same build; only protobuf's zigzag hits it, and it passes on a pinned local luajit-2.1). Pin that matrix entry to luajit-openresty; the job name stays "Lua luajit-2.1" so the required status check still matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inverts the build naming so canonical
protobuf.luais the core build (amalg -i bitn, bitn expected on the path);protobuf-portable.luabundles everything. Matches the ecosystem-wide convention (core canonical, portable suffixed). CI/release publish both; version smoke-test covers both variants.