Add core + portable builds (core is the canonical crypto.lua)#1
Merged
Conversation
|
🦞 Reviewed the diff. Clean and well-scoped, mirrors the full/core split pattern from the sibling libs. LGTM. Verified:
Two minor heads-ups, your call:
Not blocking either way. CI: |
The canonical crypto.lua is the CORE build (bitn excluded, expected on the Lua path) so it composes with sibling libraries that share bitn without duplicating it. crypto-portable.lua bundles every dependency for zero-dependency drop-in use. CI/release publish both; the post-build version smoke-test now covers both variants. Also fixes the x25519 usage example (generate_keypair returns two values, not a table).
derek-miller
force-pushed
the
add-core-build
branch
from
July 20, 2026 16:46
261239c to
62a0cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establishes the full/core split, inverted so the canonical
crypto.luais the core build:bitnexcluded (amalg -i bitn), expected on the Lua path. Composes with sibling libraries that sharebitnwithout duplicating it.CI verifies both; release publishes both; the post-build version smoke-test now covers both variants (addresses review note #2). Artifact name kept as
crypto.lua(canonical), matching the sibling convention (addresses review note #1). Also fixes the x25519 usage example (generate_keypair()returns two values).Part of inverting the naming convention across all lua-* libs so core builds are canonical and drivers compose them with shared deps vendored once.