fix(a11y): add screen-reader landmarks and live region for streaming responses - #2210
Closed
felladrin wants to merge 1 commit into
Closed
fix(a11y): add screen-reader landmarks and live region for streaming responses#2210felladrin wants to merge 1 commit into
felladrin wants to merge 1 commit into
Conversation
…responses - Wrap MainPage content in <main> landmark for document outline - Add visually-hidden <h1> with value proposition for AT users - Add aria-live="polite" and aria-busy to streaming AI response - Forward aria attributes through FormattedMarkdown to Typography wrapper - Add tests for new landmarks and aria attribute forwarding
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Issue #2186: The streaming AI answer body had no
aria-liveregion, so assistive-tech users heard nothing as tokens arrived. Separately, the main page lacked a<main>landmark and<h1>, giving no document outline or skip target for screen-reader navigation.What Changed
client/components/Pages/Main/MainPage.tsx<main>landmark; add visually-hidden<h1>with value propositionclient/components/AiResponse/AiResponseContent.tsxaria-live="polite"andaria-busytoFormattedMarkdownclient/components/AiResponse/FormattedMarkdown.tsxaria-live/aria-busyprops to theTypographywrapperclient/components/AiResponse/FormattedMarkdown.test.tsxclient/components/Pages/Main/MainPage.test.tsx<main>landmark and hidden<h1>How Verified
MainPageFormattedMarkdownknipran clean (auto-fixed 2 unused imports)