-
-
Notifications
You must be signed in to change notification settings - Fork 104
Deduplicate custom background tasks #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
2chanhaeng
wants to merge
33
commits into
fedify-dev:feat/custom-worker
Choose a base branch
from
2chanhaeng:issue/798
base: feat/custom-worker
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d4244c7
Add custom background task API
2chanhaeng 5f9af33
Restructure mise install tasks and update docs
2chanhaeng b3070ea
Make codegen a prerequisite of the install subtasks
2chanhaeng d07ea05
Add PR #803 link in changelog
2chanhaeng 3ada130
Revive vocab nested in null-prototype objects
2chanhaeng c2a2d4c
Guard against an unparsable task started time
2chanhaeng 6c0766f
Store task definitions in a prototype-safe Map
2chanhaeng 9b3c8a5
Simplify task payload revival to a single matching reviver
2chanhaeng fc0af86
Start workers for dedicated per-task queues
2chanhaeng 058fa84
Removed overly detailed comments and unused code
2chanhaeng e8bd70d
Remove *codec-fn.ts*
2chanhaeng d88a5a1
Document the idempotent-validation requirement for task schemas
2chanhaeng 3a924f9
Reject enqueuing a task unknown to the federation
2chanhaeng a6f9137
Polish task enqueue path and queue-isolation docs
2chanhaeng 39e6ec7
Type the task codec's reviver dispatch
2chanhaeng 5237e13
Hide the task handle's phantom context-data marker
2chanhaeng 40a9948
Pin deep-nesting support in the task codec
2chanhaeng 14313a1
Reject foreign task handles by identity, not name
2chanhaeng e4f1880
Validate task payloads in the testing mock
2chanhaeng 23fc263
Hoist @standard-schema/spec to the workspace root
2chanhaeng bccbd9f
Start the queue worker on custom task enqueue
2chanhaeng 0e31bdd
Vet the whole mock task batch before any handler
2chanhaeng fc3965d
Reject foreign task handles in the testing mock
2chanhaeng ec87fc0
Use 2.x.x @since for new task APIs
2chanhaeng b444a6e
Fix doc and comment inaccuracies found in review
2chanhaeng ed60ecd
Cover enqueueTask(Many) in middleware tests
2chanhaeng 94633f1
Append revived array elements without spread
2chanhaeng e095d6c
Polish task payload docs and cover Temporal
2chanhaeng 3b5b5c8
Ignore `Temporal` test in Bun
2chanhaeng 89ff332
Support deduplicationKey for task enqueue
2chanhaeng d96293b
Extract task enqueue pipeline out of ContextImpl
2chanhaeng cbd54b3
Merge task test helpers back into tasks.ts
2chanhaeng 77a3510
Roll back dedup marker when a task enqueue fails
2chanhaeng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use concrete runnable task names instead of pseudo-syntax.
mise run test:<runtime:deno,node,bun>reads like an executable command but is placeholder syntax. Please list concrete commands (test:deno,test:node,test:bun) to avoid copy-paste failures.Suggested doc fix
🤖 Prompt for AI Agents