Speed up MathFeatures reductions with NumPy - #987
Open
Sudaiskhan1133 wants to merge 1 commit into
Open
Conversation
Sudaiskhan1133
marked this pull request as ready for review
August 19, 2026 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MathFeaturesrow-wise aggregationsddofand missing valuesaggfallback for custom functions, uncommon reducers, and nullable extension dtypesWhy
MathFeaturescurrently routes common reductions through row-wiseDataFrame.agg, which adds substantial per-row Python overhead. On a local 100,000-row x 5-feature benchmark usingsum,mean,std,min, andmax, the legacy logic took 30.49 seconds while the optimized path took 0.0159 seconds (about 1,920x faster).Compatibility
stdandvarretain pandas'ddof=1behaviorValidation
MathFeaturestests passed on pandas 2.3.3 and pandas 3.0.5flake8passedmypypassed for the changed moduleCloses #576