fix: Correct feature-server image name in Helm chart#6607
fix: Correct feature-server image name in Helm chart#6607AdityaPatil22 wants to merge 2 commits into
Conversation
| image: | ||
| # image.repository -- Docker image for Feature Server repository | ||
| repository: quay.io/feastdev/feature-server-java | ||
| repository: quay.io/feastdev/feature-server |
There was a problem hiding this comment.
@AdityaPatil22 I think the correct fix is either:
- Remove/deprecate the feast umbrella chart's feature-server subchart entirely (it's stale since Java was dropped from CI in May 2025)
- Rewrite the subchart's deployment.yaml to use feast serve like the standalone feast-feature-server chart does
You can see the Helm chart's deployment template at infra/charts/feast/charts/feature-server/templates/deployment.yaml, it has java -jar command, which won't work with python image.
There was a problem hiding this comment.
Hi @ntkathole,
Thanks for the detailed analysis!
I've updated the subchart's deployment.yaml to use feast serve instead of the legacy java -jar command, aligning it with the standalone feast-feature-server chart.
I also removed the stale Java-specific templates (configmap, secret, and ingress) simplified the values.yaml and README to reflect the current Python-based configuration.
Could you please take a look when you have a chance and let me know if everything looks good, or if there are any additional changes you'd recommend?
Signed-off-by: Aditya Patil <adpatil@redhat.com>
Signed-off-by: Aditya Patil <adpatil@redhat.com>
4a810a6 to
e155575
Compare
What this PR does / why we need it:
The Helm chart's feature-server subchart references
quay.io/feastdev/feature-server-java, which does not exist in the container registry. Thecorrect image is
quay.io/feastdev/feature-server(without the-javasuffix). This causesImagePullBackOfferrors when deploying Feast via Helm.This PR fixes the image repository name in
infra/charts/feast/charts/feature-server/values.yaml.Which issue(s) this PR fixes:
Fixes #6409
Checks
git commit -s)Testing Strategy
Verified by deploying the chart to a local Kubernetes cluster and confirming pods reach
Runningstate instead ofImagePullBackOff.