Skip to content

Preserve quoted parameter values when parsing and serializing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Preserve quoted parameter values when parsing and serializing #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/websocket/extensions/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def self.parse_header(header)
if unquoted
data = unquoted
elsif quoted
data = quoted.gsub(/\\/, '')
data = quoted.gsub(/\\([\x00-\x7f])/, '\1')
else
data = true
end
Expand Down Expand Up @@ -66,8 +66,8 @@ def self.serialize_params(name, params)
when true then values.push(key)
when Numeric then values.push(key + '=' + value.to_s)
else
if value =~ NOTOKEN
values.push(key + '="' + value.gsub(/"/, '\"') + '"')
if value == '' or value =~ NOTOKEN
values.push(key + '="' + value.gsub(/["\\]/) { |char| '\\' + char } + '"')
else
values.push(key + '=' + value)
end
Expand Down